mag/WMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

M3 Security Fixes for scan command pass 33 major code smell fixes and style fixes

Browse Source
This commit is contained in:
Mark Gregory
2026-09-17 11:34:41 +01:00
parent 0a05f05843
commit 0c445f89af
69 changed files with 1786 additions and 1752 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Modules/M3/Helpers/Helper.php
+20 -20
View File
@@ -21,7 +21,7 @@ class Helper
$token = Cache::get('token');
if (isset($token)) {
$IonToken = $token;
$ionToken = $token;
} else {
// ## CURL
// ## Generate Token
@@ -55,9 +55,9 @@ class Helper
'message' => 'Token Verification Error...' . curl_error($curl),
]);
} elseif (isset($responseJ->access_token)) {
$IonToken = $responseJ->access_token;
$ionToken = $responseJ->access_token;
Cache::put('token', $IonToken, now()->addMinutes(59));
Cache::put('token', $ionToken, now()->addMinutes(59));
} else {
return response()->json([
'code' => '400',
@@ -69,9 +69,9 @@ class Helper
curl_close($curl);
}
return $IonToken;
return $ionToken;
// 'code' => '200',
// 'token' => $IonToken
// 'token' => $ionToken
// ]);
}
@@ -88,7 +88,7 @@ class Helper
$token = Cache::get('token');
if (isset($token)) {
$IonToken = $token;
$ionToken = $token;
} else {
// ## CURL
// ## Generate Token
@@ -127,8 +127,8 @@ class Helper
'message' => 'Token Verification Error...' . curl_error($curl),
]);
} elseif (isset($responseJ->access_token)) {
$IonToken = $responseJ->access_token;
Cache::put('token', $IonToken, now()->addMinutes(59));
$ionToken = $responseJ->access_token;
Cache::put('token', $ionToken, now()->addMinutes(59));
} else {
// Clear Cache
Cache::forget('token');
@@ -143,7 +143,7 @@ class Helper
return response()->json([
'code' => '200',
'token' => $IonToken,
'token' => $ionToken,
]);
}
@@ -254,34 +254,34 @@ class Helper
public static function checkLength($JSONL, $DBL, $TYPE)
{
// Check type
$JSONType = gettype($JSONL);
$jSONType = gettype($JSONL);
switch ($JSONType) {
switch ($jSONType) {
case 'string':
$JSONTypeConv = 'string';
$jSONTypeConv = 'string';
break;
case 'double':
$JSONTypeConv = 'number';
$jSONTypeConv = 'number';
break;
case 'integer':
$JSONTypeConv = 'number';
$jSONTypeConv = 'number';
break;
default:
$JSONTypeConv = 'null';
$jSONTypeConv = 'null';
break;
}
$TYPE = $TYPE == 'integer' || $TYPE == 'DEC' ? 'number' : $TYPE;
// Check Json Field should be < DB Field
$LengthOK[413] = (strlen($JSONL) <= $DBL) ? true : false;
$lengthOK[413] = (strlen($JSONL) <= $DBL) ? true : false;
// Empty Fields
$LengthOK[411] = true; // !empty($JSONL) ? true : false ;
$lengthOK[411] = true; // !empty($JSONL) ? true : false ;
// Wrong Types
$LengthOK[417] = true; // $JSONTypeConv == $TYPE ? true : false ;
// Log::info($LengthOK);
$lengthOK[417] = true; // $jSONTypeConv == $TYPE ? true : false ;
// Log::info($lengthOK);
return $LengthOK;
return $lengthOK;
}
public static function sanityzeString($StrTosanityze)