diff --git a/Modules/Countries/Support/Iso3166.php b/Modules/Countries/Support/Iso3166.php index 49f457a5..a975e6ed 100644 --- a/Modules/Countries/Support/Iso3166.php +++ b/Modules/Countries/Support/Iso3166.php @@ -57,7 +57,7 @@ final class Iso3166 { $normalised = str_pad((string) $code, 3, '0', STR_PAD_LEFT); - if (! preg_match('/^[0-9]{3}$/', $normalised)) { + if (! preg_match('/^\d{3}$/', $normalised)) { throw new InvalidArgumentException('ISO 3166-1 numeric codes must contain exactly three digits.'); } diff --git a/Modules/Helpdesk/Resources/assets/css/app.css b/Modules/Helpdesk/Resources/assets/css/app.css index 16f7afa6..c87e40c8 100644 --- a/Modules/Helpdesk/Resources/assets/css/app.css +++ b/Modules/Helpdesk/Resources/assets/css/app.css @@ -648,10 +648,9 @@ span.flatpickr-weekday { gap: .5rem; border-radius: .85rem; padding: .62rem 1.05rem; - font-size: .875rem; + font-size: .95rem; line-height: 1.25rem; font-weight: 800; - font-size: .95rem; color: #ffffff !important; text-decoration: none !important; border: 1px solid rgba(255,255,255,.14); diff --git a/Modules/Helpdesk/Tests/Concerns/BuildsHelpdeskFixtures.php b/Modules/Helpdesk/Tests/Concerns/BuildsHelpdeskFixtures.php index d47847fb..b5ec6a9c 100644 --- a/Modules/Helpdesk/Tests/Concerns/BuildsHelpdeskFixtures.php +++ b/Modules/Helpdesk/Tests/Concerns/BuildsHelpdeskFixtures.php @@ -22,14 +22,12 @@ trait BuildsHelpdeskFixtures { protected function user(array $attributes = []): User { - /** @var User $user */ - $user = User::factory()->create(array_merge([ + /** @var User */ + return User::factory()->create(array_merge([ 'name' => 'Helpdesk User', 'email' => fake()->unique()->safeEmail(), 'password' => Hash::make('password'), ], $attributes)); - - return $user; } protected function agent(array $attributes = []): User diff --git a/app/Providers/TenancyServiceProvider.php b/app/Providers/TenancyServiceProvider.php index f4c6e83b..f36b418f 100644 --- a/app/Providers/TenancyServiceProvider.php +++ b/app/Providers/TenancyServiceProvider.php @@ -95,7 +95,7 @@ class TenancyServiceProvider extends ServiceProvider public function register() { - // + // No container bindings are required; tenancy is configured through event listeners in boot(). } public function boot() diff --git a/sonar-project.properties b/sonar-project.properties index ee646724..316ea282 100644 --- a/sonar-project.properties +++ b/sonar-project.properties @@ -9,7 +9,7 @@ sonar.exclusions=vendor/**,node_modules/**,storage/**,bootstrap/cache/**,public/ # S116: snake_case Livewire public properties intentionally mirror form/database fields. # S4833: Deployer/Laravel module bootstraps intentionally load recipe/route files. # Web title checks are not valid on Blade/Vue partials/components which are not standalone HTML documents. -sonar.issue.ignore.multicriteria=e1,e2,e3,e4,e5,e6 +sonar.issue.ignore.multicriteria=e1,e2,e3,e4,e5,e6,e7,e8 sonar.issue.ignore.multicriteria.e1.ruleKey=php:S103 sonar.issue.ignore.multicriteria.e1.resourceKey=**/*.php sonar.issue.ignore.multicriteria.e2.ruleKey=php:S1808 @@ -22,3 +22,10 @@ sonar.issue.ignore.multicriteria.e5.ruleKey=php:S4833 sonar.issue.ignore.multicriteria.e5.resourceKey=Modules/*/Providers/*ServiceProvider.php sonar.issue.ignore.multicriteria.e6.ruleKey=Web:PageWithoutTitleCheck sonar.issue.ignore.multicriteria.e6.resourceKey=**/*.{blade.php,vue} + +# Sonar CSS does not parse Tailwind v4 directives used by the application stylesheet. +sonar.issue.ignore.multicriteria.e7.ruleKey=css:S4662 +sonar.issue.ignore.multicriteria.e7.resourceKey=resources/css/app.css +# Empty module Sass entrypoints are intentional placeholders for module-owned assets. +sonar.issue.ignore.multicriteria.e8.ruleKey=css:S4667 +sonar.issue.ignore.multicriteria.e8.resourceKey=Modules/*/Resources/assets/sass/app.scss diff --git a/tests/Feature/Settings/ProfileUpdateTest.php b/tests/Feature/Settings/ProfileUpdateTest.php index fccf19fd..caf1b0ce 100644 --- a/tests/Feature/Settings/ProfileUpdateTest.php +++ b/tests/Feature/Settings/ProfileUpdateTest.php @@ -14,7 +14,7 @@ class ProfileUpdateTest extends TestCase public function test_profile_page_is_displayed(): void { - $this->actingAs($user = User::factory()->create()); + $this->actingAs(User::factory()->create()); $this->get('/settings/profile')->assertOk(); }