mag/WMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

m3 Security Fixes

Browse Source
This commit is contained in:
Mark Gregory
2026-09-16 17:31:42 +01:00
parent 1733291da2
commit 3407626e92
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Modules/M3/Http/Controllers/API/M3Controller.php
+9 -9
View File
@@ -45,7 +45,10 @@ class M3Controller extends Controller
dd('Index'); dd('Index');
} }
public function create() {} public function create()
{
// This API controller does not expose a create form.
}
public function store(Request $request) public function store(Request $request)
{ {
@@ -147,7 +150,6 @@ class M3Controller extends Controller
$CarrierCode = isset($jsonFile['CarrierCode']) ? $jsonFile['CarrierCode'] : ''; $CarrierCode = isset($jsonFile['CarrierCode']) ? $jsonFile['CarrierCode'] : '';
$ShipmentPONumber = isset($jsonFile['ShipmentPONumber']) ? $jsonFile['ShipmentPONumber'] : ''; // CustPo $ShipmentPONumber = isset($jsonFile['ShipmentPONumber']) ? $jsonFile['ShipmentPONumber'] : ''; // CustPo
$ShipTerms = isset($jsonFile['ShipTerms']) ? $jsonFile['ShipTerms'] : ''; $ShipTerms = isset($jsonFile['ShipTerms']) ? $jsonFile['ShipTerms'] : '';
// $ExchangeRate = isset($jsonFile["ExchangeRate"]) ? $jsonFile["ExchangeRate"] : '';
$OrderClass = isset($jsonFile['OrderClass']) ? $jsonFile['OrderClass'] : ''; $OrderClass = isset($jsonFile['OrderClass']) ? $jsonFile['OrderClass'] : '';
$GS1Label = isset($jsonFile['GS1-128Label']) ? $jsonFile['GS1-128Label'] : '0'; $GS1Label = isset($jsonFile['GS1-128Label']) ? $jsonFile['GS1-128Label'] : '0';
$CurrencyExchangeRate = isset($jsonFile['CurrencyExchangeRate']) ? $jsonFile['CurrencyExchangeRate'] : ''; $CurrencyExchangeRate = isset($jsonFile['CurrencyExchangeRate']) ? $jsonFile['CurrencyExchangeRate'] : '';
@@ -342,7 +344,6 @@ class M3Controller extends Controller
'ShipmentPONumber' => $ShipmentPONumber, 'ShipmentPONumber' => $ShipmentPONumber,
'ShipmentPOLine' => $ShipmentPOLine, 'ShipmentPOLine' => $ShipmentPOLine,
'ShipTerms' => $ShipTerms, 'ShipTerms' => $ShipTerms,
'ExchangeRate' => $ExchangeRate,
'OrderClass' => $OrderClass, 'OrderClass' => $OrderClass,
'LocationType' => $LocationType, 'LocationType' => $LocationType,
'PallSize' => $PallSize, 'PallSize' => $PallSize,
@@ -369,17 +370,16 @@ class M3Controller extends Controller
// Sanitize String // Sanitize String
$fieldValue = Helper::sanityzeString($fieldValues[$key] ?? ''); $fieldValue = Helper::sanityzeString($fieldValues[$key] ?? '');
// Check Var Types & Length // Check Var Types & Length
$LengthTest = Helper::checkLength($fieldValue, $value[1], $value[2]); $lengthTest = Helper::checkLength($fieldValue, $value[1], $value[2]);
if (! $LengthTest[413] || ! $LengthTest[411] || ! $LengthTest[417]) { if (! $lengthTest[413] || ! $lengthTest[411] || ! $lengthTest[417]) {
// Log::error($key .' :: '. $value[0].' :: '. $value[1] .' JSONF: '.$$keyVar .' Type: '.$value[2] ); if (! $lengthTest[413]) {
if (! $LengthTest[413]) {
$message[] = ['code' => '413', 'status' => 'error', 'message' => 'Field: ' . $key . ' is larger then expected']; $message[] = ['code' => '413', 'status' => 'error', 'message' => 'Field: ' . $key . ' is larger then expected'];
} }
if (! $LengthTest[411]) { if (! $lengthTest[411]) {
$message[] = ['code' => '411', 'status' => 'error', 'message' => 'Field: ' . $key . ' is empty']; $message[] = ['code' => '411', 'status' => 'error', 'message' => 'Field: ' . $key . ' is empty'];
} }
if (! $LengthTest[417]) { if (! $lengthTest[417]) {
$message[] = ['code' => '417', 'status' => 'error', 'message' => 'Field: ' . $key . 'type is different then Expected type: ' . $value[2]]; $message[] = ['code' => '417', 'status' => 'error', 'message' => 'Field: ' . $key . 'type is different then Expected type: ' . $value[2]];
} }
Modules/M3/Http/Controllers/utilitiesContoller.php
-1
View File
@@ -563,7 +563,6 @@ class utilitiesContoller extends Controller
// // Check if the PDF was generated correctly // // Check if the PDF was generated correctly
// if (!file_exists($tempPdfPath) || filesize($tempPdfPath) === 0) { // if (!file_exists($tempPdfPath) || filesize($tempPdfPath) === 0) {
// throw new Exception('PDF generation failed.');
// } // }
// Create an Imagick instance // Create an Imagick instance