M3 Security Fixes for Pass 39

This commit is contained in:
Mark Gregory
2026-09-17 12:52:29 +01:00
parent b8ca1e7717
commit 34e13a0bf0
16 changed files with 13 additions and 70 deletions
@@ -32,7 +32,7 @@ class pendingClosureController extends Controller
$iCM698Ma = [];
$iCM699Ma = [];
foreach ($iCM705M1 as $key => $val) {
foreach ($iCM705M1 as $val) {
$sqlstmt1 = "select LGUSER,LGCONFDT,LGCONFTM
from ICM698M
where LGCO='$val->APCO' and LGWHS='$val->APWHS'and LGURL='op605api.php'
@@ -42,7 +42,7 @@ class pendingClosureController extends Controller
$iCM698Ma[$val->APMANIFEST]['TMSUSER'] = '';
$iCM698Ma[$val->APMANIFEST]['TMSDATE'] = '';
$iCM698Ma[$val->APMANIFEST]['TMSTIME'] = '';
foreach ($iCM698M as $key2 => $val2) {
foreach ($iCM698M as $val2) {
$iCM698Ma[$val->APMANIFEST]['TMSUSER'] = $val2->LGUSER;
$iCM698Ma[$val->APMANIFEST]['TMSDATE'] = $val2->LGCONFDT;
$iCM698Ma[$val->APMANIFEST]['TMSTIME'] = $val2->LGCONFTM;
@@ -52,7 +52,7 @@ class pendingClosureController extends Controller
WHERE SHMACPKR='$val->APMANIFEST' AND SHCO='$co' AND SHWHS='$whs'
AND SHSOURCE='CloseShipmentCoChargeAPI' AND SHERROR='' AND SHTYPE='M3-Req-out' limit 1";
$iCM699MSel = DB::connection(config('m3.connection', 'pgsql'))->select($iCM699MSel1);
foreach ($iCM699MSel as $key2 => $val2) {
foreach ($iCM699MSel as $val2) {
$iCM699Ma[$val2->SHMACPKR]['SHDT'] = $val2->SHDT;
$iCM699Ma[$val2->SHMACPKR]['SHTIME'] = $val2->SHTIME;
}
@@ -73,7 +73,7 @@ class pendingClosureController extends Controller
// AND APSPARE2!=''
// dump($sqlstmt3);
$uproccessedOrders = DB::connection(config('m3.connection', 'pgsql'))->select($sqlstmt3);
foreach ($uproccessedOrders as $key => $UproccessedOrder) {
foreach ($uproccessedOrders as $UproccessedOrder) {
$unprocessedArr[] = '<a class="btn btn-link mb-1" target="_blank" href="' . url('MFOrders', ['id' => trim($UproccessedOrder->APMANIFEST)]) . '"> ' .
trim($UproccessedOrder->APMANIFEST) . '</a>';
}
@@ -107,6 +107,7 @@ class pendingClosureController extends Controller
'message' => 'Manifest Closing submitted',
]);
} catch (\Throwable $th) {
report($th);
}
}