M3 Integration fixes

Modules/Helpdesk/Tests/Concerns/BuildsHelpdeskFixtures.php

@@ -22,14 +22,12 @@ trait BuildsHelpdeskFixtures
 {
     protected function user(array $attributes = []): User
     {
-        /** @var User $user */
-        $user = User::factory()->create(array_merge([
+        /** @var User */
+        return User::factory()->create(array_merge([
             'name' => 'Helpdesk User',
             'email' => fake()->unique()->safeEmail(),
             'password' => Hash::make('password'),
         ], $attributes));
-
-        return $user;
     }
 
     protected function agent(array $attributes = []): User

Modules/Helpdesk/Tests/Feature/GitAndAttachmentTest.php

@@ -76,7 +76,6 @@ final class GitAndAttachmentTest extends TestCase
         ]);
     }
 
-
     public function test_existing_ticket_supporting_files_route_accepts_source_code_attachments(): void
     {
         Storage::fake('local');

Modules/Helpdesk/Tests/Feature/GitSpellcheckSettingsUiFilesTest.php

@@ -68,6 +68,7 @@ final class GitSpellcheckSettingsUiFilesTest extends TestCase
         self::assertStringContainsString("[&_input:not([type='checkbox']):not([type='radio']):not([type='color'])]:min-h-9", $contents);
         self::assertStringContainsString('dark:bg-zinc-950/45', $contents);
     }
+
     /**
      * Ensure settings lookup forms stay aligned and avoid oversized colour controls.
      */
@@ -91,5 +92,4 @@ final class GitSpellcheckSettingsUiFilesTest extends TestCase
         self::assertStringContainsString('h-9 w-full rounded-lg', $colourContents);
         self::assertStringNotContainsString('<flux:input', $colourContents);
     }
-
 }

Modules/Helpdesk/Tests/Feature/GitWebhookIngestionTest.php

@@ -329,5 +329,4 @@ final class GitWebhookIngestionTest extends TestCase
             'branch' => 'main',
         ]);
     }
-
 }

Modules/Helpdesk/Tests/Feature/SettingsCrudTest.php

@@ -249,7 +249,6 @@ final class SettingsCrudTest extends TestCase
         $this->assertDatabaseHas('helpdesk_products', ['id' => $product->id, 'version' => '1.1']);
     }
 
-
     public function test_helpdesk_colour_selectors_are_dropdowns_and_reject_unknown_values(): void
     {
         $this->seedLookupData();

Modules/Helpdesk/Tests/Feature/TicketConversationTest.php

@@ -4,12 +4,12 @@ declare(strict_types=1);
 
 namespace Modules\Helpdesk\Tests\Feature;
 
-use Modules\Company\Models\Company;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Http\UploadedFile;
 use Illuminate\Support\Facades\Mail;
 use Illuminate\Support\Facades\Storage;
 use Livewire\Livewire;
+use Modules\Company\Models\Company;
 use Modules\Helpdesk\Livewire\TicketShow;
 use Modules\Helpdesk\Models\Attachment;
 use Modules\Helpdesk\Models\Comment;

Modules/Helpdesk/Tests/Feature/TicketGitCommitDisplayFilesTest.php

@@ -31,7 +31,7 @@ final class TicketGitCommitDisplayFilesTest extends TestCase
         self::assertIsString($component);
         self::assertStringContainsString("\$scopeQuery->where('ticket_id', \$ticket->id)", $component);
         self::assertStringContainsString("->orWhereHas('repository'", $component);
-        self::assertStringContainsString("HD-2026-00026", "HD-2026-00026");
+        self::assertStringContainsString('HD-2026-00026', 'HD-2026-00026');
     }
 
     public function test_ticket_show_preserves_livewire_safe_expandable_sidebar_cards(): void

Modules/Helpdesk/Tests/Feature/TicketIndexDirectUserNPlusOneFilesTest.php

@@ -10,7 +10,7 @@ final class TicketIndexDirectUserNPlusOneFilesTest extends TestCase
 {
     public function test_ticket_index_eager_loads_required_relations(): void
     {
-        $source = file_get_contents(dirname(__DIR__, 2).'/Livewire/TicketIndex.php');
+        $source = file_get_contents(dirname(__DIR__, 2) . '/Livewire/TicketIndex.php');
 
         self::assertIsString($source);
 

Modules/Helpdesk/Tests/Feature/TicketIndexUserNPlusOneFilesTest.php

@@ -10,8 +10,8 @@ final class TicketIndexUserNPlusOneFilesTest extends TestCase
 {
     public function test_ticket_index_uses_scalar_agent_name(): void
     {
-        $component = file_get_contents(dirname(__DIR__, 2).'/Livewire/TicketIndex.php');
-        $view = file_get_contents(dirname(__DIR__, 2).'/Resources/views/livewire/ticket-index.blade.php');
+        $component = file_get_contents(dirname(__DIR__, 2) . '/Livewire/TicketIndex.php');
+        $view = file_get_contents(dirname(__DIR__, 2) . '/Resources/views/livewire/ticket-index.blade.php');
 
         self::assertIsString($component);
         self::assertIsString($view);

Modules/Helpdesk/Tests/Feature/TicketUserNPlusOneFilesTest.php

@@ -10,9 +10,9 @@ final class TicketUserNPlusOneFilesTest extends TestCase
 {
     public function test_ticket_queries_only_eager_load_required_relations(): void
     {
-        $index = file_get_contents(dirname(__DIR__, 2).'/Livewire/TicketIndex.php');
-        $kanban = file_get_contents(dirname(__DIR__, 2).'/Livewire/KanbanBoard.php');
-        $dashboard = file_get_contents(dirname(__DIR__, 2).'/Livewire/HelpdeskDashboardWidget.php');
+        $index = file_get_contents(dirname(__DIR__, 2) . '/Livewire/TicketIndex.php');
+        $kanban = file_get_contents(dirname(__DIR__, 2) . '/Livewire/KanbanBoard.php');
+        $dashboard = file_get_contents(dirname(__DIR__, 2) . '/Livewire/HelpdeskDashboardWidget.php');
 
         self::assertIsString($index);
         self::assertIsString($kanban);
@@ -27,7 +27,7 @@ final class TicketUserNPlusOneFilesTest extends TestCase
 
         self::assertStringContainsString("'agent:id,name,email'", $kanban);
 
-// Dashboard intentionally only loads the relations it renders.
+        // Dashboard intentionally only loads the relations it renders.
 
         self::assertStringContainsString("->with(['status', 'priority'])", $dashboard);