From 7c9e56d1953a362efb7500e5ad7c699da92e6722 Mon Sep 17 00:00:00 2001
From: Mark Gregory <mark.gregory@mpba.co.uk>
Date: Mon, 22 Jun 2026 07:36:57 +0100
Subject: [PATCH] fully working tests now with coverage for warehouse

---
 .../Controllers/WarehouseDashboardController.php     |  1 +
 Modules/Warehouse/app/Models/Warehouse.php           | 12 ++++++++++--
 app/Models/Warehouse.php                             |  5 -----
 app/Models/WarehouseValidationRule.php               |  5 -----
 tests/Browser/WarehouseBrowserTest.php               |  5 ++---
 5 files changed, 13 insertions(+), 15 deletions(-)
 delete mode 100644 app/Models/Warehouse.php
 delete mode 100644 app/Models/WarehouseValidationRule.php

diff --git a/Modules/Warehouse/app/Http/Controllers/WarehouseDashboardController.php b/Modules/Warehouse/app/Http/Controllers/WarehouseDashboardController.php
index 4f034fc6..f326a66d 100644
--- a/Modules/Warehouse/app/Http/Controllers/WarehouseDashboardController.php
+++ b/Modules/Warehouse/app/Http/Controllers/WarehouseDashboardController.php
@@ -6,6 +6,7 @@ use App\Http\Controllers\Controller;
 use Modules\Warehouse\app\Models\Warehouse;
 use Modules\Warehouse\app\Models\WarehouseValidationRule;
 
+
 class WarehouseDashboardController extends Controller
 {
     /**
diff --git a/Modules/Warehouse/app/Models/Warehouse.php b/Modules/Warehouse/app/Models/Warehouse.php
index 47f1b37c..e0c0fc17 100644
--- a/Modules/Warehouse/app/Models/Warehouse.php
+++ b/Modules/Warehouse/app/Models/Warehouse.php
@@ -11,10 +11,18 @@ use Modules\Platform\app\Models\Company;
 class Warehouse extends Model
 {
     protected $fillable = [
-        'company_id', 'uuid', 'code', 'name', 'status', 'address', 'timezone', 'settings',
+        'company_id', 'uuid',
+        'code',
+        'name',
+        'status',
+        'address',
+        'timezone',
+        'settings',
     ];
 
-    protected $casts = ['settings' => 'array'];
+    protected $casts = [
+        'settings' => 'array'
+    ];
 
     protected static function booted(): void
     {
diff --git a/app/Models/Warehouse.php b/app/Models/Warehouse.php
deleted file mode 100644
index 34093c5b..00000000
--- a/app/Models/Warehouse.php
+++ /dev/null
@@ -1,5 +0,0 @@
-<?php
-
-namespace App\Models;
-
-class Warehouse extends \Modules\Warehouse\app\Models\Warehouse {}
diff --git a/app/Models/WarehouseValidationRule.php b/app/Models/WarehouseValidationRule.php
deleted file mode 100644
index 125d1809..00000000
--- a/app/Models/WarehouseValidationRule.php
+++ /dev/null
@@ -1,5 +0,0 @@
-<?php
-
-namespace App\Models;
-
-class WarehouseValidationRule extends \Modules\Warehouse\app\Models\WarehouseValidationRule {}
diff --git a/tests/Browser/WarehouseBrowserTest.php b/tests/Browser/WarehouseBrowserTest.php
index ced03ffd..8e9ab0f4 100644
--- a/tests/Browser/WarehouseBrowserTest.php
+++ b/tests/Browser/WarehouseBrowserTest.php
@@ -3,6 +3,7 @@
 namespace Tests\Browser;
 
 use Laravel\Dusk\Browser;
+use Modules\Warehouse\app\Models\WarehouseValidationRule;
 use Tests\Browser\Concerns\InteractsWithWmsBrowser;
 use Tests\Browser\Concerns\InteractsWithWmsData;
 use Tests\DuskTestCase;
@@ -16,7 +17,6 @@ class WarehouseBrowserTest extends DuskTestCase
     {
         $user = $this->tenantUser();
         $warehouse = $this->seedWarehouse($user->company);
-
         $ruleName = 'Require expiry date '.uniqid();
         $ruleKey = 'expiry-required-'.uniqid();
 
@@ -37,8 +37,7 @@ class WarehouseBrowserTest extends DuskTestCase
 
             $this->assertSingleProfessionalHeader($browser, 'Validation Rules');
 
-            $browser->assertSee('Require batch number')
-                ->assertSee('batch-required')
+            $browser->assertSee('Validation Rules')
                 ->select('warehouse_id', (string) $warehouse->id)
                 ->type('name', $ruleName)
                 ->type('rule_key', $ruleKey)