It fixes the remaining stale test and keeps the actual N+1 strategy:
* Main ticket index renders scalar agent_name. * Ticket index still eager-loads user, owner, agent. * Ticket show comments no longer eager-load fake owner / agent relations. * Updated the conflicting regression tests.
This commit is contained in:
@@ -10,9 +10,9 @@ final class TicketUserNPlusOneFilesTest extends TestCase
|
||||
{
|
||||
public function test_ticket_collection_queries_eager_load_user_owner_and_agent(): void
|
||||
{
|
||||
$index = file_get_contents(module_path('Helpdesk', 'Livewire/TicketIndex.php'));
|
||||
$kanban = file_get_contents(module_path('Helpdesk', 'Livewire/KanbanBoard.php'));
|
||||
$dashboard = file_get_contents(module_path('Helpdesk', 'Livewire/HelpdeskDashboardWidget.php'));
|
||||
$index = file_get_contents(dirname(__DIR__, 2) . '/Livewire/TicketIndex.php');
|
||||
$kanban = file_get_contents(dirname(__DIR__, 2) . '/Livewire/KanbanBoard.php');
|
||||
$dashboard = file_get_contents(dirname(__DIR__, 2) . '/Livewire/HelpdeskDashboardWidget.php');
|
||||
|
||||
self::assertIsString($index);
|
||||
self::assertIsString($kanban);
|
||||
|
||||
Reference in New Issue
Block a user