M3 Security Fixes for Pass 34

This commit is contained in:
Mark Gregory
2026-09-17 11:45:11 +01:00
parent a25d799d13
commit a1c6362ff4
21 changed files with 4 additions and 46 deletions
@@ -19,7 +19,6 @@ class M3Controller extends Controller
// Split Data and Write to ICM666M2
public function insertToICM666M2($dataSplit, $commentData)
{
// dump($dataSplit);
$commentDataSS = explode("\n", $dataSplit);
$aXLINENO = 1;
@@ -410,7 +409,6 @@ class M3Controller extends Controller
$hazMat = isset($iCM709MSEL->AT9WRN) ? $iCM709MSEL->AT9WRN : '';
$insertArray['A1MATWRN'] = $hazMat;
// $insertArray['A1USRN01']=$palletQty;
// }
// SQL Insert to ICM666M
@@ -75,7 +75,6 @@ class M3GetPDFFromCacheController extends Controller
$aggmsg = "This delivery note is part of aggregation $aggno ";
$iCM688M1 = DB::connection(config('m3.connection', 'pgsql'))->select("select A4MACPKR from ICM688M1 where A4SHPAGGCD='$aggno'");
// foreach($iCM688M1 as $key => $ICM688M1R) {
// $aggmsg.=' <a href="M3GetPDFFromCache?MACPKR='.$ICM688M1R->A4MACPKR.'&COMPANY='.$cOMPANY.'&PLANT='.$pLANT.'&WHS='.$wHS.'">'.$ICM688M1R->A4MACPKR.'</a>';
// }
// $aggmsg.=" )";
@@ -184,7 +183,6 @@ class M3GetPDFFromCacheController extends Controller
}
} catch (\Throwable $th) {
}
// dump($aYMACPKR);
// dump($iC670M);
// dump($iCM695M1);
@@ -181,7 +181,6 @@ class OrderLinesOfClosedOrder extends Controller
$urlParams = count($request->all()) > 0 ? $request->all() : '';
$reportDate = isset($urlParams['REPORTDATE']) ? \DateTime::createFromFormat('Y-m-d', trim($urlParams['REPORTDATE']))->format('Ymd') : today()->format('Ymd');
$toreportDate = isset($urlParams['TOREPORTDATE']) ? \DateTime::createFromFormat('Y-m-d', trim($urlParams['TOREPORTDATE']))->format('Ymd') : today()->format('Ymd');
// dd($toreportDate);
$reportDateWD = isset($urlParams['REPORTDATE']) ? trim($urlParams['REPORTDATE']) : today()->format('Y-m-d');
$toreportDateWD = isset($urlParams['TOREPORTDATE']) ? trim($urlParams['TOREPORTDATE']) : today()->format('Y-m-d');
@@ -37,7 +37,6 @@ class carrierMaintController extends Controller
{
$currentUser = Helper::getUserCOWHSPLT();
$userCO = $currentUser['UserCO'] ?? '';
// $UserPL = $currentUser['UserPL'] ?? '';
// Insert record to ICM160M
// Verify record does not already exist in ICM160M
@@ -65,7 +64,6 @@ class carrierMaintController extends Controller
{
$currentUser = Helper::getUserCOWHSPLT();
$userCO = $currentUser['UserCO'] ?? '';
// $UserPL = $currentUser['UserPL'] ?? '';
// Insert record to ICM160M
if ($request->CANUM == null) {
@@ -128,7 +128,6 @@ class execSummaryController extends Controller
break;
}
// dump($toreportDate);
// dump($selectContent);
$execSummaryRes = DB::connection(config('m3.connection', 'pgsql'))->select($selectContent);
} else {
@@ -86,8 +86,6 @@ class palletQtyController extends Controller
public static function saveQtyEdit(Request $request)
{
// console.log($request);
// where AT9CO='$request->AT9CO' and AT9PLT='$request->AT9PLT' and AT9WHS='$request->AT9WHS' and AT9PART='$request->AT9PART'");
// var_dump($icm709m);
@@ -89,7 +89,6 @@ class pendingClosureController extends Controller
{
// Get URL PARAMS
$urlParams = count($request->all()) > 0 ? $request->all() : '';
// $SHUSER = isset($urlParams["SHUSER"]) ? $urlParams["SHUSER"] : '';
$mANIFEST = isset($urlParams['MANIFEST']) ? $urlParams['MANIFEST'] : '';
$aPCO = isset($urlParams['APCO']) ? $urlParams['APCO'] : '';
$aPWHS = isset($urlParams['APWHS']) ? $urlParams['APWHS'] : '';
@@ -229,7 +229,6 @@ class userControlController extends Controller
// Successful Call
else {
// $AWREQN = $result['io_param']["var0"];
// return "success";
if ($request->ACTION == 'P') {
echo "<script>alert('The password has been reset to QAZ1WSX2 for '" . $request->USERID . "'. The user will need to enter a new password on next green screen connection.');</script>";
}
@@ -289,7 +288,6 @@ class userControlController extends Controller
}
// $params[] = $conn->AddParameterChar('in', 10, 'userid','USRPRF',$request->USERID);
// $params[] = $conn->AddParameterChar('in', 10, 'pwd','PASSWORD',$request->PASSWORD);
// $params[] = $conn->AddParameterChar('in', 9, 'sts','STATUS','*ENABLED');
// $params[] = $conn->AddParameterChar('in', 4, 'pwdexp','PWDEXP','*NO');
@@ -103,7 +103,7 @@ class userPickingStats5 extends Controller
{
$statistics = [];
$count = 0;
$url = 'http://' . $request->server('HTTP_HOST') . '/userPickingStats4';
$url = $request->getSchemeAndHttpHost() . '/userPickingStats4';
for ($day = 0; $day <= $days; $day++) {
$date = date('Y-m-d', strtotime($starting . "+$day days"));
@@ -415,8 +415,6 @@ class utilitiesContoller extends Controller
{
print_r('>>> Generate PDF');
// $image = $builder->output('(10)123456(400)11(3906)333333');
// $builder->setBarcodeType('gs1-128');
// $builder->setFilename('barcode.png');
// $builder->setImageFormat('png');