added support for legacy tickets, fixed switching of modes and also style updates

Modules/Helpdesk/Http/Controllers/NativeTicketController.php

@@ -7,44 +7,144 @@ namespace Modules\Helpdesk\Http\Controllers;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
-use Illuminate\Support\Facades\DB;
+use Illuminate\Validation\Rule;
 use Modules\Helpdesk\Models\Ticket;
+use Modules\Helpdesk\Services\TicketService;
 
 final class NativeTicketController extends Controller
 {
+    public function __construct(
+        private readonly TicketService $tickets,
+    ) {}
+
     public function index(Request $request): JsonResponse
     {
         $user = $request->user();
-        $query = Ticket::query()->orderByDesc('id');
-        if (!$user->can('helpdesk.admin')) {
-            $query->where(function ($q) use ($user) { $q->where('user_id', $user->getKey())->orWhere('agent_id', $user->getKey()); });
+
+        $query = Ticket::query()
+            ->visibleTo($user)
+            ->orderByDesc('id');
+
+        if ($request->filled('search')) {
+            $search = addcslashes(
+                (string) $request->query('search'),
+                '%_\\'
+            );
+
+            $query->where(
+                'subject',
+                'like',
+                '%'.$search.'%'
+            );
         }
-        if ($search = $request->query('search')) {
-            $query->where('subject', 'like', '%'.addcslashes((string) $search, '%_\\').'%');
-        }
-        return response()->json($query->paginate(30));
+
+        return response()->json(
+            $query->paginate(30)
+        );
     }
 
     public function show(Request $request, Ticket $ticket): JsonResponse
     {
-        $this->authorizeTicket($request, $ticket);
-        return response()->json($ticket->load(['comments', 'status', 'priority', 'agent']));
+        $user = $request->user();
+
+        $ticket = Ticket::query()
+            ->visibleTo($user)
+            ->whereKey($ticket->getKey())
+            ->firstOrFail();
+
+        return response()->json(
+            $ticket->load([
+                'comments',
+                'status',
+                'priority',
+                'category',
+                'project',
+                'team',
+                'agent',
+                'attachments',
+                'tags',
+            ])
+        );
     }
 
     public function store(Request $request): JsonResponse
     {
-        $data = $request->validate(['subject' => ['required','string','max:255'], 'body' => ['required','string']]);
-        $ticket = DB::transaction(function () use ($request, $data) {
-            return Ticket::create($data + [
-                'reference' => 'MAC-'.strtoupper(bin2hex(random_bytes(6))),
-                'user_id' => $request->user()->getKey(),
-            ]);
-        });
-        return response()->json($ticket, 201);
-    }
+        $data = $request->validate([
+            'subject' => [
+                'required',
+                'string',
+                'max:255',
+            ],
+            'body' => [
+                'required',
+                'string',
+            ],
+            'priority_id' => [
+                'required',
+                'integer',
+                Rule::exists('helpdesk_priorities', 'id'),
+            ],
+            'category_id' => [
+                'nullable',
+                'integer',
+                Rule::exists('helpdesk_categories', 'id'),
+            ],
+            'project_id' => [
+                'nullable',
+                'integer',
+                Rule::exists('helpdesk_projects', 'id'),
+            ],
+            'product_id' => [
+                'nullable',
+                'integer',
+                Rule::exists('helpdesk_products', 'id'),
+            ],
+            'team_id' => [
+                'nullable',
+                'integer',
+                Rule::exists('helpdesk_teams', 'id'),
+            ],
+            'board_id' => [
+                'nullable',
+                'integer',
+                Rule::exists('helpdesk_kanban_boards', 'id'),
+            ],
+            'due_at' => [
+                'nullable',
+                'date',
+            ],
+            'tag_ids' => [
+                'sometimes',
+                'array',
+            ],
+            'tag_ids.*' => [
+                'integer',
+                'distinct',
+                Rule::exists('helpdesk_tags', 'id'),
+            ],
+            'attachments' => [
+                'sometimes',
+                'array',
+            ],
+            'attachments.*' => [
+                'file',
+                'max:10240',
+            ],
+        ]);
 
-    private function authorizeTicket(Request $request, Ticket $ticket): void
-    {
-        abort_unless($request->user()->can('helpdesk.admin') || (int) $ticket->user_id === (int) $request->user()->getKey() || (int) $ticket->agent_id === (int) $request->user()->getKey(), 403);
+        $files = $request->file('attachments', []);
+
+        unset($data['attachments']);
+
+        $ticket = $this->tickets->create(
+            $request->user(),
+            $data,
+            $files
+        );
+
+        return response()->json(
+            $ticket,
+            201
+        );
     }
 }