M3 Integration fixes pass 27

# Conflicts:
#	Modules/Helpdesk/changelog.yaml

.env.dusk.local

@@ -0,0 +1,16 @@
+APP_URL=http://127.0.0.1:8000
+SESSION_DRIVER=file
+CACHE_STORE=array
+
+APP_KEY=base64:O0djxuJapvByUFNx5avmY7od6Y6C05JYv3kAFNrlrMX=
+DB_CONNECTION=pgsql
+DB_HOST=127.0.0.1
+DB_PORT=5432
+DB_DATABASE=wms_dusk
+DB_USERNAME=wms_user
+DB_PASSWORD=987400Kmh
+QUEUE_CONNECTION=sync
+MAIL_MAILER=array
+DEBUGBAR_ENABLED=false
+
+TELESCOPE_ENABLED=false

.gitignore

@@ -39,3 +39,4 @@ composer.lock
 /storage/framework/
 /storage/debugbar/
 /phpunit.dusk.xml
+sonarqube-issues.csv

Modules/Analytics/README.md

@@ -1,5 +0,0 @@
-# Analytics
-
-Display KPIs, warehouse performance trends, executive summaries, and OTTC analysis.
-
-Contains actual sample Blade views and placeholder service provider/routes only.

Modules/Analytics/Resources/views/index.blade.php

@@ -64,6 +64,7 @@
                     <div class="card-body">
                         <div class="table-responsive">
                             <table class="table table-hover align-middle mb-0">
+                                <caption class="sr-only">Data table</caption>
                                 <thead class="table-light">
                                     <tr>
                                         <th>Metric</th>

Modules/Audit/README.md

@@ -1,5 +0,0 @@
-# Audit
-
-Review activity logs, data changes, interface events, and administrative actions.
-
-Contains actual sample Blade views and placeholder service provider/routes only.

Modules/Audit/Resources/views/index.blade.php

@@ -64,6 +64,7 @@
                     <div class="card-body">
                         <div class="table-responsive">
                             <table class="table table-hover align-middle mb-0">
+                                <caption class="sr-only">Data table</caption>
                                 <thead class="table-light">
                                     <tr>
                                         <th>When</th>

Modules/AuditTrail/Providers/AuditTrailServiceProvider.php

@@ -63,9 +63,7 @@ class AuditTrailServiceProvider extends ServiceProvider
         $commandPath = __DIR__ . '/../Console';
         $commands = collect(File::allFiles($commandPath))
             ->map(function ($file) {
-                $class = 'Modules\\' . $this->moduleName . '\\Console\\' . $file->getFilenameWithoutExtension();
-
-                return $class;
+                return 'Modules\\' . $this->moduleName . '\\Console\\' . $file->getFilenameWithoutExtension();
             })
             ->filter(function ($class) {
                 return class_exists($class);

Modules/AuditTrail/Providers/RouteServiceProvider.php

@@ -14,18 +14,6 @@ class RouteServiceProvider extends ServiceProvider
      */
     protected $moduleNamespace = 'Modules\AuditTrail\Http\Controllers';
 
-    /**
-     * Called before routes are registered.
-     *
-     * Register any model bindings or pattern based filters.
-     *
-     * @return void
-     */
-    public function boot()
-    {
-        parent::boot();
-    }
-
     /**
      * Define the routes for the application.
      *

Modules/CarrierManagement/README.md

@@ -1,5 +0,0 @@
-# Carrier Management
-
-Maintain carriers, services, and shipment routing master data.
-
-Contains actual sample Blade views and placeholder service provider/routes only.

Modules/CarrierManagement/Resources/views/index.blade.php

@@ -64,6 +64,7 @@
                     <div class="card-body">
                         <div class="table-responsive">
                             <table class="table table-hover align-middle mb-0">
+                                <caption class="sr-only">Data table</caption>
                                 <thead class="table-light">
                                     <tr>
                                         <th>Carrier</th>

Modules/ChatGPT/Console/DeleteOpenAiFilesCommand.php

@@ -26,40 +26,37 @@ class DeleteOpenAiFilesCommand extends Command
             return self::FAILURE;
         }
 
-        $service = new OpenAiFileService((string) $setting->api_key);
-
         try {
-            if ((bool) $this->option('dry-run')) {
-                $files = $service->listFiles();
-
-                $this->info('Found ' . count($files) . ' OpenAI API file(s).');
-
-                foreach ($files as $file) {
-                    $this->line(sprintf(
-                        '- %s %s',
-                        (string) ($file['id'] ?? 'unknown'),
-                        (string) ($file['filename'] ?? 'unnamed'),
-                    ));
-                }
-
-                return self::SUCCESS;
-            }
-
-            $result = $service->deleteAllFiles();
-
-            $this->info("Listed: {$result['listed']}");
-            $this->info("Deleted: {$result['deleted']}");
-            $this->info("Failed: {$result['failed']}");
-
-            foreach ($result['failures'] as $failure) {
-                $this->error($failure['file_id'] . ': ' . $failure['error']);
-            }
-
-            return $result['failed'] === 0 ? self::SUCCESS : self::FAILURE;
+            return $this->executeFor(new OpenAiFileService((string) $setting->api_key));
         } catch (Throwable $exception) {
             $this->error($exception->getMessage());
 
             return self::FAILURE;
         }
     }
+
+    private function executeFor(OpenAiFileService $service): int
+    {
+        if ((bool) $this->option('dry-run')) {
+            $files = $service->listFiles();
+            $this->info('Found ' . count($files) . ' OpenAI API file(s).');
+
+            foreach ($files as $file) {
+                $this->line(sprintf('- %s %s', (string) ($file['id'] ?? 'unknown'), (string) ($file['filename'] ?? 'unnamed')));
+            }
+
+            return self::SUCCESS;
+        }
+
+        $result = $service->deleteAllFiles();
+        $this->info("Listed: {$result['listed']}");
+        $this->info("Deleted: {$result['deleted']}");
+        $this->info("Failed: {$result['failed']}");
+
+        foreach ($result['failures'] as $failure) {
+            $this->error($failure['file_id'] . ': ' . $failure['error']);
+        }
+
+        return $result['failed'] === 0 ? self::SUCCESS : self::FAILURE;
+    }
 }

Modules/ChatGPT/Database/Seeders/ChatGPTDatabaseSeeder.php

@@ -16,6 +16,5 @@ class ChatGPTDatabaseSeeder extends Seeder
     {
         Model::unguard();
 
-        // $this->call("OthersTableSeeder");
     }
 }

Modules/ChatGPT/Exceptions/OpenAiFileException.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Modules\ChatGPT\Exceptions;
+
+use RuntimeException;
+
+final class OpenAiFileException extends RuntimeException {}

Modules/ChatGPT/Providers/ChatGPTServiceProvider.php

@@ -79,9 +79,7 @@ class ChatGPTServiceProvider extends ServiceProvider
         $commandPath = __DIR__ . '/../Console';
         $commands = collect(File::allFiles($commandPath))
             ->map(function ($file) {
-                $class = 'Modules\\' . $this->moduleName . '\\Console\\' . $file->getFilenameWithoutExtension();
-
-                return $class;
+                return 'Modules\\' . $this->moduleName . '\\Console\\' . $file->getFilenameWithoutExtension();
             })
             ->filter(function ($class) {
                 return class_exists($class);

Modules/ChatGPT/Providers/RouteServiceProvider.php

@@ -14,18 +14,6 @@ class RouteServiceProvider extends ServiceProvider
      */
     protected $moduleNamespace = 'Modules\ChatGPT\Http\Controllers';
 
-    /**
-     * Called before routes are registered.
-     *
-     * Register any model bindings or pattern based filters.
-     *
-     * @return void
-     */
-    public function boot()
-    {
-        parent::boot();
-    }
-
     /**
      * Define the routes for the application.
      *

Modules/ChatGPT/Resources/views/index.blade.php

@@ -65,7 +65,8 @@
                 </div>
 
                 <label class="inline-flex items-center gap-2 text-sm text-slate-700">
-                    <input type="checkbox" name="is_active" value="1" checked class="rounded border-slate-300 text-blue-600 focus:ring-blue-500">
+                    <label for="sonar-input-a09f3b253f" class="visually-hidden">is active</label>
+<input type="checkbox" name="is_active" value="1" checked class="rounded border-slate-300 text-blue-600 focus:ring-blue-500" id="sonar-input-a09f3b253f">
                     Make active key
                 </label>
 
@@ -82,6 +83,7 @@
 
             <div class="mt-5 overflow-x-auto">
                 <table class="min-w-full divide-y divide-slate-200 text-sm">
+                    <caption class="sr-only">Data table</caption>
                     <thead class="bg-slate-50 text-left text-xs font-semibold uppercase tracking-wide text-slate-500">
                         <tr>
                             <th class="px-4 py-3">Name</th>
@@ -99,24 +101,27 @@
                                         @csrf
                                         @method('PUT')
 
-                                        <input
+                                        <label for="sonar-input-30f47d1294" class="visually-hidden">name</label>
+<input
                                             name="name"
                                             type="text"
                                             value="{{ old('name', $setting->name) }}"
                                             class="w-full rounded-lg border-slate-300 text-sm shadow-sm focus:border-blue-500 focus:ring-blue-500"
-                                        >
+                                         id="name">
 
-                                        <input
+                                        <label for="sonar-input-707eb8d2ba" class="visually-hidden">Leave blank to keep existing key</label>
+<input
                                             name="api_key"
                                             type="password"
                                             value=""
                                             autocomplete="new-password"
                                             placeholder="Leave blank to keep existing key"
                                             class="w-full rounded-lg border-slate-300 text-sm shadow-sm focus:border-blue-500 focus:ring-blue-500"
-                                        >
+                                         id="sonar-input-707eb8d2ba">
 
                                         <label class="inline-flex items-center gap-2 text-xs text-slate-600">
-                                            <input
+                                            <label for="sonar-input-da782f0360" class="visually-hidden">is active</label>
+<input
                                                 type="checkbox"
                                                 name="is_active"
                                                 value="1"

Modules/ChatGPT/Services/OpenAiFileService.php

@@ -4,7 +4,7 @@ namespace Modules\ChatGPT\Services;
 
 use Illuminate\Http\Client\PendingRequest;
 use Illuminate\Support\Facades\Http;
-use RuntimeException;
+use Modules\ChatGPT\Exceptions\OpenAiFileException;
 
 class OpenAiFileService
 {
@@ -33,7 +33,7 @@ class OpenAiFileService
                 ->get(self::BASE_URL . '/files', $query);
 
             if ($response->failed()) {
-                throw new RuntimeException('OpenAI file list request failed: ' . $response->body());
+                throw new OpenAiFileException('OpenAI file list request failed: ' . $response->body());
             }
 
             $payload = $response->json();
@@ -63,7 +63,7 @@ class OpenAiFileService
             ->delete(self::BASE_URL . '/files/' . rawurlencode($fileId));
 
         if ($response->failed()) {
-            throw new RuntimeException("OpenAI file delete request failed for {$fileId}: " . $response->body());
+            throw new OpenAiFileException("OpenAI file delete request failed for {$fileId}: " . $response->body());
         }
 
         return $response->json() ?? [];
@@ -90,7 +90,7 @@ class OpenAiFileService
             try {
                 $this->deleteFile($fileId);
                 $deleted++;
-            } catch (RuntimeException $exception) {
+            } catch (OpenAiFileException $exception) {
                 $failures[] = [
                     'file_id' => $fileId,
                     'error' => $exception->getMessage(),